feat: add module for a kotlin plugin #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMeinerLP
requested changes
Nov 3, 2025
| publishing.repositories(repos -> repos.maven(maven -> { | ||
| String version = p.getVersion().toString(); | ||
| String baseUrl = version.contains("SNAPSHOT") | ||
| ? "https://repo.onelitefeather.dev/onelitefeather-snapshots" |
There was a problem hiding this comment.
This should be a property for gradle or system property
There was a problem hiding this comment.
This would be a separate pull request and isn’t really related to this one
Comment on lines
+21
to
+23
| applyCommonPlugins(project); | ||
| configureTesting(project); | ||
| configurePublishing(project); |
There was a problem hiding this comment.
How would you design such conditions? Just using properties? I’m not very experienced in writing plugins, so I can’t suggest the best solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The pull request adds a module which contains a kotlin plugin which does the same as the given java plugin.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.